Box: support realtime event stream #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can also split this PR up, if needed. |
boneskull
commented
Jun 27, 2018
| @@ -224,7 +287,7 @@ describe('box nodes', function() { | |||
| var onStub = sinon.stub(box, 'on').callsFake(function(event, cb) { | |||
| var res = onFunction.apply(box, arguments); | |||
| onStub.restore(); | |||
| box.emit('input', {}); // trigger poll | |||
| box.emit('check-events', {}); // trigger poll | |||
There was a problem hiding this comment.
I thought it best to rename this event, because it's confusing. This is not a real input event; the box in Node has no inputs.
boneskull
commented
Jun 27, 2018
box/box.js
Outdated
| return; | ||
| } | ||
| if (!(data.entries && data.entries.length)) { | ||
| node.fail(new Error('Invalid response from Box')); |
|
still working out some kinks |
|
I'm going to withdraw this, as other changes I'm making supercede it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
box inNode to monitor the event log via long polling instead of interval-based polling. This enables (roughly) real-time events to come down the pipe.BoxNodeInfor DRYI could spend a lot longer with the tests. I'm also experiencing an unrelated test failure locally in the Instagram node.
Checklist
gruntto verify the unit tests pass